search

dragoonDorise / EmuDeck

Emulator configurator for Steam Deck
GNU General Public License v3.0
2.75k stars 200 forks source link

Cloud Backup/Sync: fixed silent failures #1141

Closed mdeabreu closed 3 months ago

mdeabreu commented 3 months ago

The quoting in this subshell was causing issues with the $HOME substitution, which would result in method failing and returning a non-zero result, which would cause the emulatorInit body to fail to run cloud_sync_startService (since it was using && to run subsequent commands), which meant the syncing/backing up service was completely down.

How to test With a reasonably working setup on the main branch, try launching an emulated game, play for a bit and then save and exit. Log into your cloud provider of choice and notice that the save has not been updated. Additionally verify this by checking the $HOME/emudeck/logs/CloudWatcher.log log file has not been updated. Apply the changes here and relaunch a game, save and exit. Verify that the cloud copy of the save has been updated and the log file contains information from the watcher.

dragoonDorise commented 3 months ago

Hey @mdeabreu thanks for the PR but I also happen to have fixed it on my own so I'm closing the PR without merging since we did the same fix. :)