search

dragoonDorise / EmuDeck

Emulator configurator for Steam Deck
GNU General Public License v3.0
2.74k stars 200 forks source link

[Issue #1232] Fix launch argument parsing in PCSX2 shell script #1233

Closed mykbit closed 2 weeks ago

mykbit commented 1 month ago

The code provided substitutes all single quotes within the argument list with double quotes. That is achieved by sed "s/'/\"/g". Unlike the older version, it avoids accidental changes to the argument values and ensures consistent substitution of single quotes with double quotes.

rawdatafeel commented 3 weeks ago

This still seems to have difficulty with launching ROMs that have single apostrophes in their name ("The Dog's Bone" as a fake title/example). The current script has the same issue and it would be nice to have that fixed as well.

I have a draft PR here that does fix the single apostrophe issue, https://github.com/dragoonDorise/EmuDeck/pull/1250, but I would be curious to hear your thoughts, it should fix your issue as well.

I think we could remove the -fullscreen flag from the script as well and move that to the SRM parser so users can add whatever flags they want.

mykbit commented 3 weeks ago

Hi! I've tested your pcsx2-qt.sh file in #1250 and it works flawlessly for me. I'm sorry for not taking into account the case where roms have single quotes in my PR. Thank you for fixing this issue!

P.S. I think removing -fullscreen flags is a good idea. Having a standard config, which can be later modified by SRM or in Steam launch options, makes much more sense.

rawdatafeel commented 2 weeks ago

Hi! I've tested your pcsx2-qt.sh file in #1250 and it works flawlessly for me. I'm sorry for not taking into account the case where roms have single quotes in my PR. Thank you for fixing this issue!

P.S. I think removing -fullscreen flags is a good idea. Having a standard config, which can be later modified by SRM or in Steam launch options, makes much more sense.

Not a problem, it was just an issue that's been bugging me.

Contributions are always wonderful and very welcome though :) if you would like to join the EmuDeck discord and assign yourself the new contributor role, it'd be great to have you!

mykbit commented 2 weeks ago

I'm closing this PR, since the issue was resolved in #1250. Thank you!