search

dragoonDorise / EmuDeck

Emulator configurator for Steam Deck
GNU General Public License v3.0
2.91k stars 211 forks source link

Dolphin compression broken: dolphin-tool alias breaks -f test in chddeck.sh #633

Closed gclawes closed 1 year ago

gclawes commented 1 year ago

This change to the dolphin-tool breaks the -f check for the original flatpak file path.

Change: https://github.com/dragoonDorise/EmuDeck/commit/dc808a3fc9677a17eccd003d7e1470c03325855a

https://github.com/dragoonDorise/EmuDeck/blob/28ff221930f7de566b79c8f5f3a278f073ea4ddd/tools/chdconv/chddeck.sh#L46

The $dolphinTool variable no longer exists, it was: /var/lib/flatpak/app/io.github.shiiion.primehack/current/active/files/bin/dolphin-tool

As a result, dolphin games are no longer compressed by the tool.

gclawes commented 1 year ago

Log from chddeck.sh:

Checking /home/deck/Emulation/roms for files eligible for conversion.
Checking /home/deck/Emulation/roms/dreamcast/
Checking /home/deck/Emulation/roms/psx/
Checking /home/deck/Emulation/roms/segacd/
Checking /home/deck/Emulation/roms/3do/
Checking /home/deck/Emulation/roms/saturn/
Checking /home/deck/Emulation/roms/tg-cd/
Checking /home/deck/Emulation/roms/pcenginecd/
Checking /home/deck/Emulation/roms/pcfx/
Checking /home/deck/Emulation/roms/amigacd32/
Checking /home/deck/Emulation/roms/neogeocd/
Checking /home/deck/Emulation/roms/megacd/
Checking /home/deck/Emulation/roms/ps2/
No eligible files found.
gclawes commented 1 year ago

With the dolphinTool=... line manually re-inserted:

Checking /home/deck/Emulation/roms for files eligible for conversion.
Checking /home/deck/Emulation/roms/dreamcast/
Checking /home/deck/Emulation/roms/psx/
Checking /home/deck/Emulation/roms/segacd/
Checking /home/deck/Emulation/roms/3do/
Checking /home/deck/Emulation/roms/saturn/
Checking /home/deck/Emulation/roms/tg-cd/
Checking /home/deck/Emulation/roms/pcenginecd/
Checking /home/deck/Emulation/roms/pcfx/
Checking /home/deck/Emulation/roms/amigacd32/
Checking /home/deck/Emulation/roms/neogeocd/
Checking /home/deck/Emulation/roms/megacd/
Checking /home/deck/Emulation/roms/ps2/
Checking /home/deck/Emulation/roms/gamecube/
found in gamecube
Checking /home/deck/Emulation/roms/wii/
Checking /home/deck/Emulation/roms/primehacks/
User selected gamecube
Converting: /home/deck/Emulation/roms/gamecube/Simpsons, The - Hit & Run (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Pikmin (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Luigi's Mansion (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Sonic Adventure DX - Director's Cut (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Viewtiful Joe 2 (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Metroid Prime (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Super Mario Sunshine (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Mario Kart - Double Dash!! (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Metroid Prime 2 - Echoes (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Final Fantasy - Crystal Chronicles (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Sonic Adventure 2 - Battle (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Animal Crossing (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Viewtiful Joe (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Pikmin 2 (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/Super Smash Bros. Melee (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Converting: /home/deck/Emulation/roms/gamecube/SSX Tricky (USA).iso
/home/deck/Emulation/tools/chdconv/chddeck.sh: line 159: dolphin-tool: command not found
Godsbane commented 1 year ago

Yes it's corrected in the beta, and dynamic based on what flatpaks are available.

Godsbane commented 1 year ago

duplicate of #588

closing this one