Develop - Githubissues

alexarchambault commented 7 years ago

This PR replaces the assembly-based launch of the server with one using coursier. That has two advantages IMO:

local development is a bit more lightweight, it now only requires a simple sbt publishLocal rather than an assembly generation, and
that should make it easier to release the server: its scala modules can just be pushed to a repository (Central say). There's no need to make assemblies available somewhere. The server classpath is simply fetched using the coursier launcher.

This works by shipping the coursier launcher in the vsix file (it's downloaded during the vsce package), which is then used by the typescript code to launch the server.

The server version is currently hardcoded in the typescript code (set to 0.1.1-SNAPSHOT in this PR), and would need to be edited prior to releases / version bumps.

dragos commented 7 years ago

This is excellent work, thanks! I'm trying it out now.

dragos commented 7 years ago

It works well, thank you! What I'm not sure about is this log output that I see when debugging (F5 in the scala subdirectory):

Error: certificate has expired
    at Error (native)
    at TLSSocket.<anonymous> (_tls_wrap.js:1060:38)
    at emitNone (events.js:86:13)
    at TLSSocket.emit (events.js:185:7)
    at TLSSocket._finishInit (_tls_wrap.js:584:8)
    at TLSWrap.TLSSocket._init.ssl.onhandshakedone (_tls_wrap.js:416:38)

There are a few of those stack traces, but I don't see how it can have anything to do with coursier. So I'm going to merge this.

Thanks a lot!

dragos / dragos-vscode-scala

Develop #19