Declare configuration settings in manifest

dragos / dragos-vscode-scala

Other

253 stars 39 forks source link

Declare configuration settings in manifest #71

Closed xuebingli closed 6 years ago

xuebingli commented 6 years ago

@dragos

Fix "Unknown configuration settings" error as reported in #70 by @Blaisorblade.
Set default value of scalaLanguageServer.logLevel to INFO

xuebingli commented 6 years ago

@dragos currently log level does not have a default value, thus undefined is passed in.

$ jps -v
8912 Jps -Dapplication.home=/Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home -Xms8m
8862 coursier -Xmx4G -Dvscode.workspace=/Users/xli/Code/test-proj -Dvscode.logLevel=undefined

What do you reckon the default value should be?

dragos commented 6 years ago

thank you! I think the deafault log level should be INFO

xuebingli commented 6 years ago

@dragos Done. Please review :)