search

dragos / dragos-vscode-scala

Other
253 stars 39 forks source link

[Discussion] [Live Share] Restricting language services to local files #82

Closed lostintangent closed 6 years ago

lostintangent commented 6 years ago

In preparation for Visual Studio Live Share adding support for "guests" to receive remote language services for Scala, this PR simply updates the current DocumentSelector to be limited to file and untitled (unsaved) files. This way, when someone has the Scala extension installed, and joins a Live Share session (where files use the vsls: scheme), their language services will be entirely derived from the remote/host side, which provides a more accurate and project-wide experience (guests in Live Share don't have local file access to the project they're collaborating with).

Note: As an example, the TypeScript/JavaScript language services that come in-box with VS Code already have this scheme restriction, and so this PR replicates that behavior.

dragos commented 6 years ago

Thanks!

lostintangent commented 6 years ago

@dragos Do you have plans to release an update to the marketplace any time soon? If possible, I'd love to have this change published as part of your next push. Thanks!

dragos commented 6 years ago

I'll release this Friday.

lostintangent commented 6 years ago

@dragos Did you plan to update the extension in the marketplace anytime soon? I'd love to have rock-solid Scala support in Live Share :)

dragos commented 6 years ago

Yeah, I wish I could... now navigating the labyrinth of publishing, it seems my token expired after 1 year and can't get publishing to work anymore

dragos commented 6 years ago

Ok, should be up on the marketplace now.