dragos / typesafe-config-eclipse

An Eclipse plugin for Typesafe Config files
Apache License 2.0
23 stars 6 forks source link

Support concatenation of arrays #19

Closed mkurz closed 7 years ago

mkurz commented 7 years ago

We are in a situation where we want to prepend an element to an array. HOCON does allow that, however the plugin doesn't recognize the syntax :(

@dragos If you could merge that and release a new version that would be really great! We already made a custom built and use the plugin with this PR included and it works great. Thank you!

dragos commented 7 years ago

Thank you!

dragos commented 7 years ago

If you're interested in maintaining the project I can look into giving you rights to release on Bintray. Hopefully it's not too complicated.

mkurz commented 7 years ago

@dragos Yeah, why not? If you can grant me rights I will see what I can do :smile:

Also I just recognized that my PR ruined the outline view... Pretty sure because of (value += Array)+... Do you have an idea how to fix this?

1

dragos commented 7 years ago
mkurz commented 7 years ago

Actually I alrady fixed the outline :smile:

mkurz commented 6 years ago

@dragos Can you please release a new version? Thanks!

mkurz commented 6 years ago

... or give me publish permissions? :wink:

dragos commented 6 years ago

I'm trying to release, but I'm running into some failed dependencies that come from nexus.codehaus.org, which is no longer available. I'll see what I need to do to upgrade.

mkurz commented 6 years ago

@dragos A while ago I built it myself and published it in our local repository. What I did:

# make sure everything is clean:
find -name generated | xargs rm -rf ;
find -name generated-sources | xargs rm -rf ;
find -name src-gen | xargs rm -rf ;
find -name xtend-gen | xargs rm -rf ;
find -name target | xargs rm -rf ;

cd com.typesafe.hocon.releng/ ;
mvn -e install ;

# Now see the zip file in ~/.m2/repository/com/typesafe/hocon/com.typesafe.hocon.updatesite/${VERSION_FOLDER}
dragos commented 6 years ago

I'm getting a lot of

[WARNING] Checksum validation failed, expected <!DOCTYPE but is b6e79499f3d2a39bc5a2d77ca2ae3ef002b9d1ea for http://nexus.codehaus.org/snapshots/org/eclipse/emf/org.eclipse.emf.codegen/2.10.0-v20140127-SNAPSHOT/maven-metadata.xml

while downloading dependencies, no idea where these dependencies are coming from..

mkurz commented 6 years ago

Just now I removed my ~/.m2 folder and built the project again. Everything worked.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] parent ............................................. SUCCESS [  2.213 s]
[INFO] Typesafe Config Core ............................... SUCCESS [ 57.480 s]
[INFO] Typesafe Config UI ................................. SUCCESS [  2.353 s]
[INFO] Typesafe Config Tests .............................. SUCCESS [  3.979 s]
[INFO] Typesafe Config Feature ............................ SUCCESS [  0.085 s]
[INFO] Typesafe Config Update Site ........................ SUCCESS [  1.450 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 05:27 min
[INFO] Finished at: 2017-09-08T14:03:27+02:00
[INFO] Final Memory: 129M/1379M
[INFO] ------------------------------------------------------------------------

I am using maven 3.5:

$ mvn -version
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T21:39:06+02:00)
Maven home: /opt/maven/maven-3.5
Java version: 1.8.0_144, vendor: Oracle Corporation
Java home: /opt/jdk1.8.0_144/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.10.0-33-generic", arch: "amd64", family: "unix"
dragos commented 6 years ago

I pushed a release. I also created a new Bintray organization, I'll send you an invite. You should then be able to release there. (current release is in the old place)

dragos commented 6 years ago

Do you have a Bintray username?

mkurz commented 6 years ago

I just signed up now, it's mkurz

dragos commented 6 years ago

Can you confirm that you can publish to the new repository? Perhaps a re-take of 1.0.6, and if all works out we can change the official repo to be the new one.