search

dragotin / kraft

Kraft helps to handle your daily quotes and invoices in your small business.
http://volle-kraft-voraus.de
GNU General Public License v2.0
60 stars 19 forks source link

Icon Kuddlmuddl #11

Closed dragotin closed 2 years ago

dragotin commented 7 years ago

The Kraft specific icons should be in the resource file, the others taken from the theme. Currently the cmake installing is not clean.

dragotin commented 6 years ago

Also, add Documents- and Timeline icon to the resource pack.

dragotin commented 6 years ago
dragotin commented 6 years ago

might be fixed by #32. Check!

dragotin commented 2 years ago

Also double check the use of icons: Some are duplicates, such as the Document - create icons. @moini

Moini commented 2 years ago

Thanks for tackling this.

I'm now using the self-built version, and icons still look a bit off in the preferences (different sizes), as well as in the main button row (all identical):

grafik

The icons in the document edit dialog look alright in my build:

grafik

Disclaimer: did not try the AppImage. Should I? I'd rather wait until the icons work okay in one place before we move to the next.

dragotin commented 2 years ago

Icons can either come from the system "theme" (ie. the icons installed on the system) or be bundled with the app. No standard linux distro icon set contains all the icons Kraft would need, or with the correct size. That is the reason for the small icons you see.

So at some point I started to put icons into the app bundle, but not all have been handled there. I can not draw icons myself, and also have a hard time to look for icons.

The ideal solution would be to find an icon set that provides all icons Kraft needs. Maybe you want to help?

The three identical icons are indeed correct, as I used the same one for all three "create" actions. I will try to find a better solution.

dragotin commented 2 years ago

Fixed duplicate icons with d7406c2c919ebcfee202e6d3d6e67a52557fe97d

Another aspect here: I am picking the icons from the KDE theme (breeze). Users who run the app on other desktops might miss icons that are not in their set. Sigh.

Moini commented 2 years ago

The previous duplicates are distinguishable now, thank you!

The copy icon is a bit unusual - it looks more like it were a dissolving document in my installation - is that intended? grafik

Sure, I think I'd be able to find some icons for you. I'm not familiar with Qt/KDE icon handling, only know how to create gtk-compatible icon sets, as in https://gitlab.com/inkscape/inkscape/-/tree/master/share/icons/hicolor - is it the same principle?

dragotin commented 2 years ago

Sorry for getting back late on this.

Yes, same principle. SVG is great. It makes probably sense if, at some point, Kraft has all icons that it needs in it's own resources, rather than taking from the window managers theme. if you could help with that, I'd be really grateful.

Moini commented 2 years ago

Okay - schau ich mir frühestens gegen Monatsende an, aber das sollte ja auch noch reichen. Frohes Neues Jahr, @dragotin!

dragotin commented 2 years ago

Es reicht wann immer du Zeit dafür aufbringen magst :-) Happy new Year!

dragotin commented 2 years ago

Obsoleted by #175