dragotin / kraft

Kraft helps to handle your daily quotes and invoices in your small business.
http://volle-kraft-voraus.de
GNU General Public License v2.0
58 stars 18 forks source link

Port to KF5Grantlee #117

Closed kossebau closed 2 years ago

kossebau commented 2 years ago

There is an active plan to import Grantlee as KDE Frameworks module in time for KDE Frameworks 5.88 begin of November. Not yet set in stone, but worked for right now.

See https://phabricator.kde.org/T14887 for details.

The KF varient of Grantlee will not be a drop-in replacement, but needs some adaption on CMake & code level, as done by this patch. This patch is the currently needed adaption to that. So this MR is just a preview of what will be needed.

Ideally would be part of a new Kraft release together with #116 in time for KDE Gear 21.12. So Linux distributions can switch all their packages to KFGrantlee and avoid any potential symbol clashes (as the Grantlee C++ namespace is used also in the KF variant).

dragotin commented 2 years ago

This PR is still marked as Draft - @kossebau could you doublecheck please?

kossebau commented 2 years ago

KFGrantlee still needs more time to sort out the interest of all stakeholders. Which might take some more months sadly, no schedule currently. Might only happen in Q1 of 2022.

So MR has to stay as draft some more. If you dislike draft MRs with no schedule behind, please close for now. And once things are moving again, there is still some work to start from. Whatever you prefer.

dragotin commented 2 years ago

That is fine, lets leave it for now. Thanks.

kossebau commented 2 years ago

Given the Grantlee author now works themselves on a new version for KF6 called KTextTemplate, discarding this one now.