dragotin / kraft

Kraft helps to handle your daily quotes and invoices in your small business.
http://volle-kraft-voraus.de
GNU General Public License v2.0
58 stars 18 forks source link

Grantlee is documented to be optional, but cmake errors out without it #123

Closed Moini closed 2 years ago

Moini commented 2 years ago

As the AppImage said the template file that was included doesn't work (see screenshot - weasyprint installed via pip3, not sure whether it's actually included or needs to be available on the system...?), I've tried to compile kraft. grafik

Now I'm stuck at a contradiction between docs (https://github.com/dragotin/kraft/blob/41e10028cce5d9c3a9009687dbb68cab180b8c9d/INSTALL#L41) and cmake - is Grantlee required or not?

141329129-b5b1d92d-dee9-44ef-afdb-1f98d9c8265f

Some package names for installation on Ubuntu:

extra-cmake-modules
libkf5i18n-dev
libkf5xmlgui-dev
libkf5contacts-dev

added after reply:
libctemplate-dev
libgrantlee5-dev

Q1: Is it expected that the AppImage html-type template does not work?
Q2: Is weasyprint included or does it need to be installed separately?
Q3: Is the documentation outdated or is the cmake script too strict?

dragotin commented 2 years ago

Thanks for this report.... Nasty stuff and hard to check on a developer machine where everything is installed.

I updated the INSTALL file, hopefully it is more accurate now. Btw, libkf5xmlgui-dev should not be needed any more, I cleaned the KF5 deps at some point.

Indeed grantlee is mandatory, since it is way better than the ctemplate solution keeping it obsolete only lasted shortly ;-)

Answers to your questions:

dragotin commented 2 years ago

Fixed with commit be04c0a

Moini commented 2 years ago

Thank you, @dragotin , cmake succeeded!

(Can't tell whether weasyprint was picked up by the AppImage, the error message wasn't clear on that - might have been the template, might have been the not-found module).