search

dragotin / kraft

Kraft helps to handle your daily quotes and invoices in your small business.
http://volle-kraft-voraus.de
GNU General Public License v2.0
56 stars 18 forks source link

Fix build with akonadi-contacts 22.04 #136

Closed tcberner closed 2 years ago

dragotin commented 2 years ago

Hi @tcberner thanks for your PR! I am having trouble to compile that on older versions (here: 21.12) because the include AkonadiContact/akonadi-contact_version.h can not be found, but is included unconditionally.

An earlier check uses AKONADI_VERSION to check for the version of Akonadi (probably in general, not specifically the contact part) - would that be an option?

What do you recommend?

tcberner commented 2 years ago

Hi @tcberner thanks for your PR! I am having trouble to compile that on older versions (here: 21.12) because the include AkonadiContact/akonadi-contact_version.h can not be found, but is included unconditionally.

An earlier check uses AKONADI_VERSION to check for the version of Akonadi (probably in general, not specifically the contact part) - would that be an option?

What do you recommend?

Oh sorry, you are right -- that file is indeed new too in 22.04. I guess the easiest thing would be to check the version in cmake

dragotin commented 2 years ago

What do you think about ec3bbf65fad73605ab9d16a4d09e9f1b4f6c47bf?

tcberner commented 2 years ago

What do you think about ec3bbf6?

Looks like it should work to me, apart from the one unmasked include.

dragotin commented 2 years ago

Indeed, thanks :-)