dragotin / kraft

Kraft helps to handle your daily quotes and invoices in your small business.
http://volle-kraft-voraus.de
GNU General Public License v2.0
60 stars 19 forks source link

Missing icons in AppImage #149

Closed stefanbaur closed 2 years ago

stefanbaur commented 2 years ago

image

Hi Klaas,

Comparing the two regions in the screenshot above, the green region has icons, while the red one does not. This happens when using the Appimage "kraft-master-0.98+git13+g006b8bf-lp152.50.1.Build3.2.glibc2.17-x86_64.AppImage", but also with older versions.

I haven't tried out non-AppImage versions yet.

Is this intentional?

Kind Regards, Stefan

noseshimself commented 2 years ago

I have the same problem with the AppImage AND the Debian package. The only way for me to get the icons showing on Debian is compiling the package myself and I have yet to find out why I suddenly succeeded....

It might be necessary to talk to the release engineer doing the Debian package and talk about all the things found in https://lintian.debian.org/sources/kraft and update the packaging process.

Ionic commented 2 years ago

Stefan's original issue was caused by him using a Trinity (i.e., KDE 3) icon theme, which doesn't support/supply icons such as edit-copy, folder-documents etc.

Newer Plasma (KDE 5, maybe even 4) themes do, though, so it's actually a theming issue.

This said, QIcon::fromTheme can be given a fallback icon in case the icon theme does not provide the icon it has been queried for, and the fallback icon can be baked into the binary (as a QResource). I'd advise shipping and providing fallback icons for things that might not be available in themes.

dragotin commented 2 years ago

Same problem here: grafik

noseshimself commented 2 years ago

I don't have the slightest idea where the icons are coming from on my system. A "naked" ChromeOS Debian container doesn't have much pre-installed GUI lebraries at all -- you would be surprised about the stuff being brought in by apt install xterm.

dragotin commented 2 years ago

Obsoleted by #175