dragotin / kraft

Kraft helps to handle your daily quotes and invoices in your small business.
http://volle-kraft-voraus.de
GNU General Public License v2.0
60 stars 19 forks source link

Bug: Initial default document numbering starts with "1" #163

Open noseshimself opened 2 years ago

noseshimself commented 2 years ago

As the number is the last used document number unaware users will start with their first document actually being #2.

dragotin commented 2 years ago

Please elaborate. Where? What?

noseshimself commented 2 years ago

The lastIdentNumber value in numberCyles is exactly that: The last number used. When creating a new row in the table the selected inisial value shold be 0 to start a newly created counter at 1. But creating a new entry will offer you 1 as initial value (unless you created a document bedore doing so -- at that point it will offer you lastIdentNzmber od that document+1 as initial value). This might surprise users and might lead to creation of a document (that can't be erased) with an unexpected document number. It would be better to always present 0 as initial value.