Build failure against akonadi-contacts-23.08

[a17r]

from git master:

[  1%] Generating mo...
[  1%] Built target pofiles-e656871aed0338a82c3fd7938e658933
[  2%] Generating ts...
[  2%] Built target tsfiles-e656871aed0338a82c3fd7938e658933
[  2%] Automatic MOC for target kraftlib
[  2%] Built target kraftlib_autogen
[  3%] Generating ui_xrechnung.h
[  4%] Generating databasesettings.h, databasesettings.cpp
[  4%] Generating kraftsettings.h, kraftsettings.cpp
[  4%] Generating qrc_kraft.cpp
src/pics/kraft.qrc: Warning: potential duplicate alias detected: 'arrow-down.svg'
src/pics/kraft.qrc: Warning: potential duplicate alias detected: 'arrow-up.svg'
src/pics/kraft.qrc: Warning: potential duplicate alias detected: 'edit.svg'
src/pics/kraft.qrc: Warning: potential duplicate alias detected: 'file-plus.svg'
src/pics/kraft.qrc: Warning: potential duplicate alias detected: 'edit.svg'
src/pics/kraft.qrc: Warning: potential duplicate alias detected: 'minus.svg'
[  5%] Generating ui_calctemplate.h
[  5%] Generating ui_createdb.h
[  6%] Generating ui_dbinit.h
[  7%] Generating ui_dbselect.h
[  8%] Generating ui_docfooter.h
[  8%] Generating ui_docheader.h
[  9%] Generating ui_doctypeeditbase.h
src/doctypeeditbase.ui: Warning: The name 'gridLayout' (QGridLayout) is already in use, defaulting to 'gridLayout2'.
[  9%] Generating ui_fixpartui.h
[  9%] Generating ui_identity.h
[ 10%] Generating ui_importtodocbase.h
src/importtodocbase.ui: Warning: The name 'gridLayout' (QGridLayout) is already in use, defaulting to 'gridLayout1'.
[ 10%] Generating ui_inserttmplbase.h
[ 11%] Generating ui_materialdialog.h
[ 12%] Generating ui_matpartui.h
[ 12%] Generating ui_mysqldetails.h
[ 12%] Generating ui_numbercycleseditbase.h
[ 13%] Generating ui_positionwidget.h
[ 14%] Generating ui_sqlitedetails.h
[ 15%] Generating ui_statuspage.h
[ 15%] Generating ui_taxeditbase.h
[ 15%] Generating ui_texteditbase.h
[ 16%] Generating ui_timepart.h
[ 16%] Generating ui_unitseditbase.h
[ 16%] Generating ui_upgradedb.h
[ 17%] Generating ui_wageseditbase.h
[ 17%] Building CXX object src/CMakeFiles/kraftlib.dir/kraftlib_autogen/mocs_compilation.cpp.o
In file included from build/src/kraftlib_autogen/EWIEGA46WW/moc_addressselectorwidget.cpp:10,
                 from build/src/kraftlib_autogen/mocs_compilation.cpp:6:
build/src/kraftlib_autogen/EWIEGA46WW/../../../../src/addressselectorwidget.h:34:10: fatal error: AkonadiContact/Akonadi/ContactViewer: No such file or directory
   34 | #include <AkonadiContact/Akonadi/ContactViewer>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [src/CMakeFiles/kraftlib.dir/build.make:255: src/CMakeFiles/kraftlib.dir/kraftlib_autogen/mocs_compilation.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:552: src/CMakeFiles/kraftlib.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

Maybe some part of https://github.com/dragotin/kraft/pull/202 is necessary after all?

[t-8ch]

These are the changes I needed to make it work: https://aur.archlinux.org/cgit/aur.git/tree/0001-akonadi-contacts-5.24.0.patch?h=kraft

For the upstream kraft repo they'll need some adaption but it's a starting point.

[a17r]

Maybe you want to submit a PR? That's usually how this works.

[t-8ch]

I do know how it works.

But it needs some subjective adaptions. Opening a PR and discussing these adaptions will take much longer than @dragotin picking up the changes and just doing the adaptions himself.

[dragotin]

Thanks for reporting this. Please check PR #210. It should work with new and also older Akonadis now. I would be grateful if anybody could check that with the latest, newest Akonadi that caused this bug report. I do not have that recent versions at hand. Thanks!

Note the build switch as described in the PR.

[a17r]

Worked fine for me against 23.08, thanks.

[dragotin]

Awesome, thanks everybody