dragotin / kraft

Kraft helps to handle your daily quotes and invoices in your small business.
http://volle-kraft-voraus.de
GNU General Public License v2.0
58 stars 18 forks source link

Added Akonadi version check for some renamed components #210

Closed dragotin closed 1 year ago

dragotin commented 1 year ago

This PR contains Akonadi version checks for components that were renamed in Akonadi version 5.24. Akonadi renamed the contact viewer and editors namespace.

With this PR, that should be automatically detected and build should work for version from 5.24 on but also older releases.

Note for old Akonadi that still has the KF5 instead of KPim5 prefix, cmake must be called with a build switch:

cmake -DAKONADI_LEGACY_BUILD=ON ..

See #209

t-8ch commented 1 year ago
/home/t-8ch/src/kraft/src/addressselectorwidget.cpp: In member function ‘void AddressSelectorWidget::slotEditContact()’:
/home/t-8ch/src/kraft/src/addressselectorwidget.cpp:413:30: error: expected type-specifier
  413 |         _addressEditor = new Akonadi::ContactEditorDialog(Akonadi::ContactEditorDialog::EditMode, this);
      |                              ^~~~~~~
dragotin commented 1 year ago

@t-8ch yes, of course ;-/

pushed another fix.

t-8ch commented 1 year ago

Works fine now, thanks!

dragotin commented 1 year ago

Ah that's terrific! Thanks for providing the solution and testing :-)

t-8ch commented 1 year ago

Happy to help :-)