search

dragotin / kraft

Kraft helps to handle your daily quotes and invoices in your small business.
http://volle-kraft-voraus.de
GNU General Public License v2.0
60 stars 19 forks source link

Building from tarball fails #211

Closed EbonJaeger closed 1 year ago

EbonJaeger commented 1 year ago

This commit (https://github.com/dragotin/kraft/commit/e9aa6e953243848a5f8acf5958d7c6fd5e68339d) tries to check for a .tag file in the absence of a .git directory, but there is no such file in the GitHub auto-generated source tarballs. I think for this to work, you would have to tar the source directory yourself and upload it when making the release. Projects that do this generally script it to minimize the effort.

dragotin commented 1 year ago

Ok, thanks for the report, this is annoying.

The quick fix is to create a file .tag in the root of the unpacked tarball which should contain the SHA of the last commit.

This command creates a correct tarball: git archive --format=tar --prefix=kraft-1.1/ --add-file=.tag v1.1 | xz>kraft-1.1.tar.xz

It would be awesome if Githubs release mechanism would include that as an option.