search

dragouf / Stash-Reviewers-Chrome-Extension

This chrome/firefox extension allow to define groups of reviewers in Atlassian Stash/Bitbucket to bulk add them when creating or updating pull request + other features
MIT License
88 stars 34 forks source link

Dropdown button doesn't appear #3

Closed damianpi closed 8 years ago

damianpi commented 8 years ago

Hello, At first, I just want to say that this plugin is really great. However, I have one problem with it. Whereas I was able to install the plugin (both on Firefox and Chrome), there is no button on the pull request page. The tool appears in the browser, so I am able to define and save groups, but the button to choose the group on the reviewers (pull request) page does not. I am using Stash v.4.2.0, which is actually Bitbucket now. Is there any chance this will work properly, or am I doing something wrong?

Regards, Damian

dragouf commented 8 years ago

Hi Damian,

Yes it seems they renamed everything in bitbucket server. I will create a new branch for that soon.

dragouf commented 8 years ago

It's fixed. You can find the working version onto 'bitbucket-server-version' branch here:

https://github.com/dragouf/Stash-Reviewers-Chrome-Extension/tree/bitbucket-server-version

please tell me if it works now.

damianpi commented 8 years ago

Thank you for your help! It works great on Chrome, but not on Firefox. There, the dropdown button (near the Reviewers field) does not appear at all.

dragouf commented 8 years ago

Ah yes I made a big mistake. I used chrome api in ff extension. It should work now.

Also make sure that xpinstall.signatures.required in about:config is set to false to allow unsigned extension to be executed. And don't forget to edit package.json and main.js file inside xpi file to set your bitbucket server url. (xpi file is just a zip file. You can edit it with 7zip for example)

Please tell me if it works!

damianpi commented 8 years ago

Everything works great now, thank you! If I could only suggest one more small thing - the distribution can be renamed from "stash-reviewers..." to "bitbucket-reviewers..." in order to avoid possible confusion.

dragouf commented 8 years ago

Yes it would be better for understanding. Thanks for your suggestion.