dragouf / Stash-Reviewers-Chrome-Extension

This chrome/firefox extension allow to define groups of reviewers in Atlassian Stash/Bitbucket to bulk add them when creating or updating pull request + other features
MIT License
88 stars 34 forks source link

Inbox Dialog Doesn't Load #44

Closed ammmze closed 6 years ago

ammmze commented 6 years ago

So a few weeks ago the inbox stopped working when I have this plugin enabled. I haven't been able to track down the exact cause yet though. But when I click the inbox it just opens with blank content (regardless of whether I have PR's open). It looks like this...

Alt text

Also have an error in the JS console...

descriptor.js?_statichash=baf6aa6069686b3fea866e1cb01526b4-T%2F1017787519%2Fed8fbbd%2F112%2F3.8.0&locale=en-US:formatted:15 Uncaught TypeError: Cannot read property 'repoName' of undefined
    at view (descriptor.js?_statichash=baf6aa6069686b3fea866e1cb01526b4-T%2F1017787519%2Fed8fbbd%2F112%2F3.8.0&locale=en-US:formatted:15)
    at t (web-section.js?_statichash=7e1d6964fe49e5c2aff9cb697c396da1-T%2F1017787519%2Fed8fbbd%2F112%2F5b45cad464152ad2ffe79d3aaa653efe&analytics-enabled=true&analytics-uploadable=true&locale=en-US&nps-acknowledged=true&nps-enabled=true&supportedApplication=true:formatted:1)
    at Object._getWebPanels (web-section.js?_statichash=7e1d6964fe49e5c2aff9cb697c396da1-T%2F1017787519%2Fed8fbbd%2F112%2F5b45cad464152ad2ffe79d3aaa653efe&analytics-enabled=true&analytics-uploadable=true&locale=en-US&nps-acknowledged=true&nps-enabled=true&supportedApplication=true:formatted:1)
    at c.getWebPanels (web-section.js?_statichash=7e1d6964fe49e5c2aff9cb697c396da1-T%2F1017787519%2Fed8fbbd%2F112%2F5b45cad464152ad2ffe79d3aaa653efe&analytics-enabled=true&analytics-uploadable=true&locale=en-US&nps-acknowledged=true&nps-enabled=true&supportedApplication=true:formatted:1)
    at b.value (web-section.js?_statichash=7e1d6964fe49e5c2aff9cb697c396da1-T%2F1017787519%2Fed8fbbd%2F112%2F5b45cad464152ad2ffe79d3aaa653efe&analytics-enabled=true&analytics-uploadable=true&locale=en-US&nps-acknowledged=true&nps-enabled=true&supportedApplication=true:formatted:1)
    at p._renderValidatedComponentWithoutOwnerOrContext (web-section.js?_statichash=7e1d6964fe49e5c2aff9cb697c396da1-T%2F1017787519%2Fed8fbbd%2F112%2F5b45cad464152ad2ffe79d3aaa653efe&analytics-enabled=true&analytics-uploadable=true&locale=en-US&nps-acknowledged=true&nps-enabled=true&supportedApplication=true:formatted:1)
    at p._renderValidatedComponent (web-section.js?_statichash=7e1d6964fe49e5c2aff9cb697c396da1-T%2F1017787519%2Fed8fbbd%2F112%2F5b45cad464152ad2ffe79d3aaa653efe&analytics-enabled=true&analytics-uploadable=true&locale=en-US&nps-acknowledged=true&nps-enabled=true&supportedApplication=true:formatted:1)
    at performInitialMount (web-section.js?_statichash=7e1d6964fe49e5c2aff9cb697c396da1-T%2F1017787519%2Fed8fbbd%2F112%2F5b45cad464152ad2ffe79d3aaa653efe&analytics-enabled=true&analytics-uploadable=true&locale=en-US&nps-acknowledged=true&nps-enabled=true&supportedApplication=true:formatted:1)
    at p.mountComponent (web-section.js?_statichash=7e1d6964fe49e5c2aff9cb697c396da1-T%2F1017787519%2Fed8fbbd%2F112%2F5b45cad464152ad2ffe79d3aaa653efe&analytics-enabled=true&analytics-uploadable=true&locale=en-US&nps-acknowledged=true&nps-enabled=true&supportedApplication=true:formatted:1)
    at Object.mountComponent (web-section.js?_statichash=7e1d6964fe49e5c2aff9cb697c396da1-T%2F1017787519%2Fed8fbbd%2F112%2F5b45cad464152ad2ffe79d3aaa653efe&analytics-enabled=true&analytics-uploadable=true&locale=en-US&nps-acknowledged=true&nps-enabled=true&supportedApplication=true:formatted:1)

But everything in the stack trace originates from the bitbucket server js files, which is why I'm having a hard time nailing down the cause here.

We are running BitBucket v5.0.2. I'm not sure what all plugins we have enabled as I am not a BitBucket admin, but I know we have Sonar, Workzone, and Awesome Graphs (based on the stuff I can see in my own repositories settings)

ammmze commented 6 years ago

It looks like that Inbox uses react (and maybe the only thing on the page using react). Perhaps they recently switched that to react?

ammmze commented 6 years ago

I just found if I disable the following, the inbox will start working again...

EDIT: Maybe not...maybe something is caching...it's hit or miss. But with those disabled I am at least sometimes able to get the inbox. With them enabled, I never saw the inbox.

ammmze commented 6 years ago

This appears to be working again. We must have updated one of our plugins because it doesn't look like this extension has been updated.