search

dragouf / Stash-Reviewers-Chrome-Extension

This chrome/firefox extension allow to define groups of reviewers in Atlassian Stash/Bitbucket to bulk add them when creating or updating pull request + other features
MIT License
88 stars 34 forks source link

Fix pr edit reviewers for new bitbucket #51

Closed stellarashes closed 6 years ago

stellarashes commented 6 years ago

Based on the branch from #50

Reviewer groups do not pop up for me in new bitbucket because the plugin is listening for an old, deprecated dialog event that bitbucket (at least the instance we're running) no longer seems to use.

Old dialog: https://docs.atlassian.com/aui/7.8.0/docs/dialog.html?_ga=2.162510652.1878890867.1526064900-1734121638.1523970510 New dialog (and events): https://docs.atlassian.com/aui/7.8.0/docs/dialog2.html

This will allow reviewer button show on when attempting to edit an existing PR on bitbucket using their newer dialog.

stellarashes commented 6 years ago

Updated the PR. Initially I replaced the code to only listen for the new dialog event. It later occurred to me that this would break for people who might still be on an older version of stash that is still using the old dialog. So I've refactored it to listen to both events, for backwards compatibility.

curtiswellborn commented 6 years ago

Somebody merge this...the plugin is not usable in the newer version without this @dragouf

dragouf commented 6 years ago

sorry I have no time to maintain it a lot since I don't use bitbucket anymore after I move to another company. Now it's merged !

stellarashes commented 6 years ago

Thanks!