search

dragouf / Stash-Reviewers-Chrome-Extension

This chrome/firefox extension allow to define groups of reviewers in Atlassian Stash/Bitbucket to bulk add them when creating or updating pull request + other features
MIT License
88 stars 34 forks source link

CheckForUpdate is failing, Cant reach github message is showed #54

Open davidbaena opened 6 years ago

davidbaena commented 6 years ago

Hello! When I updated the plugin to 2.2.14 version(Mac 10.13.2) I got the following dialog:

New version of the extension (cant.reach.github)
Please check you added your bitbucket server domain to extension manifest.json

It seems like chrome can't reach github in order to check the last version of the plugin. This request returns a undefined response in data:

window.communication.runtime.sendMessage(window.chromeExtId, {
                    method: 'GET',
                    action: 'xhttp',
                    url: 'https://raw.githubusercontent.com/dragouf/Stash-Reviewers-Chrome-Extension/master/version'
                }, function(data) {
                    if(!data) {
                        data = {
                            response: 'cant.reach.github'
                        };
                    }

But the endpoint works fine if i get this URL from chrome. It responses 2.2.14 version

How can solve it? I don't know how to add the bitbucket server to the manifest.

ggabdol commented 6 years ago

I'm getting this message, too.

dragouf commented 6 years ago

I think this check is useless. It was used when this extension was self hosted. I will remove it.

karpach commented 6 years ago

I'm getting this message, too.

cnnranderson commented 6 years ago

I stopped getting this message, but now I'm getting a new one related to the PR list view. I'll make a new issue around it.

edwinramirez commented 5 years ago

Version 2.2.15 and this issue still occurs.