search

dragouf / Stash-Reviewers-Chrome-Extension

This chrome/firefox extension allow to define groups of reviewers in Atlassian Stash/Bitbucket to bulk add them when creating or updating pull request + other features
MIT License
88 stars 34 forks source link

Getting error trying to use this extension with bitbucket #65

Open Rab815 opened 4 years ago

Rab815 commented 4 years ago

Uncaught Error: AMD module bitbucket-plugin/pullrequest-list-modifier must not depend on internal module(s) bitbucket/internal/feature/pull-request/pull-request-table.

The server extension drop list isn't even showing on the PR page. I'm just getting a console error.

Doug

zzzep commented 4 years ago

@dragouf , any solution for this issue?

Rab815 commented 4 years ago

none!

On Mon, Jan 27, 2020 at 8:57 AM zzzep notifications@github.com wrote:

@dragouf https://github.com/dragouf , any solution for this issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dragouf/Stash-Reviewers-Chrome-Extension/issues/65?email_source=notifications&email_token=ABTYL6OQG3KCRV42WJJ75CLQ73R4NA5CNFSM4J2WYCLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ7SKAY#issuecomment-578757891, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTYL6LN5EK64S7UHKJCDJLQ73R4NANCNFSM4J2WYCLA .

stanmarsh2 commented 3 years ago

@ra100 @zzzep Folks, if you need just to replace the list of reviewers - I've written a JS script for BitBucket 6.7 based on this repo's source code and can publish it. It is run with the help of ViolentMonkey on chosen domain and creates a link "REVIEWERS" that replaces the list.

Gist: https://gist.github.com/alex-borkun/01df7f4c9a65f39f1705138ca973cc19

ra100 commented 3 years ago

The gist script looks similar to this: https://github.com/dragouf/Stash-Reviewers-Chrome-Extension/blob/master/extension/chrome/src/js/stash_page.js#L357-L414 What is the main difference? I guess the issue, metioned above, is problem with PR list. Maybe just disabling the list would solve the issue.

stanmarsh2 commented 3 years ago

@ra100 yes, code works. Did not expect that bitbucket has jquery. I've reverse-engineered the API requests as I made a wrong conclusion based on GitHub issues that API has been changed ;) Thanks, updated the code to contain original code, also added license declaration and reference to original code.

I guess the issue, metioned above, is problem with PR list. Maybe just disabling the list would solve the issue.

My Bitbucket server throws an Error with an url containing the issue description:

Uncaught Error: AMD module bitbucket-plugin/pullrequest-list-modifier must not depend on internal module(s) bitbucket/internal/feature/pull-request/pull-request-table. See the API changelog for details: https://developer.atlassian.com/server/bitbucket/reference/api-changelog/#expected-future-changes at g (require-lite.js?....)
https://developer.atlassian.com/server/bitbucket/reference/api-changelog/#expected-future-changes

Internal JS/AMD modules blocked Similar to the above, some internal AMD modules were depended on by plugins. In 6.0, third-party plugins that depend on modules starting with bitbucket/internal/ will stop working. Where an equivalent public API is available, use that. Otherwise, consider implementing your own version of the functionality. Some exceptions were made for heavily used modules, but these will eventually be replaced with supportable implementations of API and will also be removed removed a future major version update.

Seems they've blocked some internal API and it won't worked without major refactoring.