search

dragouf / Stash-Reviewers-Chrome-Extension

This chrome/firefox extension allow to define groups of reviewers in Atlassian Stash/Bitbucket to bulk add them when creating or updating pull request + other features
MIT License
88 stars 34 forks source link

Clicking the extension icon no longer navigates to bitbucket #71

Closed j0be closed 4 years ago

j0be commented 4 years ago

Prior to the latest release, clicking the icon would navigate to the bitbucket site you have locally. Mine is pointed to a internally hosted bitbucket server.

Clicking the icon now shows this:

Screen Shot 2020-10-29 at 15 37 01

Modifying this does nothing and will not save anything entered.

Zykalus commented 4 years ago

Same issue here. My hosted bitbucket server does not match the pattern given.

guy-premont-cml commented 4 years ago

same issue here reinstalling did not change anything type the a pattern that should work ://bitbucket:7990/ and pressing save just brings back the same original pattern displayed

But, strangely, the icon shows the number of PR that are assigned to me. image

ra100 commented 4 years ago

So it seems, that value is stored, but is not loaded/prefilled in the field.

j0be commented 4 years ago

I found why it's no longer launching.

Here is the original code to handle the icon click: Screen Shot 2020-11-02 at 15 23 06

Here is the documentation from Google regarding chrome.browserAction.onClicked: Screen Shot 2020-11-02 at 15 22 14

And here's the addition that caused it in manifest.json: Screen Shot 2020-11-02 at 15 23 19

https://github.com/dragouf/Stash-Reviewers-Chrome-Extension/commit/17ec94edb8550742c77e052360f2820a02442aa8

j0be commented 4 years ago

I've created a pull request to fix this: https://github.com/dragouf/Stash-Reviewers-Chrome-Extension/pull/72

j0be commented 4 years ago

@Zykalus. @premont, @BaconGirl, @jiemi

Feel free to update and test my fix to see if this fixes your issue.

@ra100 / @premont, I'm pretty sure this issue can be closed as long as no one raises any concerns now the update is live

guy-premont-cml commented 4 years ago

Yes it works perfectly now. Thanks!

BaconGirl commented 4 years ago

Edit: I reinstalled the extension and I couldnt get it to work until I navigated to the dashboard url and then it started working by itself 😮

j0be commented 4 years ago

@BaconGirl, yeah. The extension stores a setting called currentStashBaseUrl, which is the last stash url you visited that matched your host filters. I'm not sure why that would get unset through normal activity. But on a new install, that wouldn't be set so it will need to have you browse to the stash url that matches your host filter before this fix works for it.