search

dragozzine / multimoon

fit solar system small body multiple systems with non-Keplerian orbits including quadrupole shapes
MIT License
5 stars 0 forks source link

Initialization of state vectors assumes the second input body is the largest moon/satellite #13

Closed benp175 closed 3 years ago

benp175 commented 3 years ago

https://github.com/dragozzine/multimoon/blob/b1c16687dd40534a8f2b751c3911bff74019b13f/src/mm_SPINNY/spinny_nosun.py#L34

Assuming the second body is the most massive moon/satellite conflicts with other parts of the code that require the satellites to be in order from closest to furthest.

Should be an easy fix to switch it to instead choose the most massive moon/satellite. Some thought should be put into whether there's a better way to do this, especially if you have two ~equal mass moons.

benp175 commented 3 years ago

This might not be true. SPinny seems to possibly reorder the bodies by mass.

benp175 commented 3 years ago

Bodies are sorted by mass, so this isn't an issue. Closing this for now.