dragozzine / multimoon

fit solar system small body multiple systems with non-Keplerian orbits including quadrupole shapes
MIT License
5 stars 0 forks source link

Mutual inc calculation is wrong #19

Closed benp175 closed 2 years ago

benp175 commented 2 years ago

https://github.com/dragozzine/multimoon/blob/ee5c149fd3df6a1cf554c436fb14ee02da8c2f99/src/mm_priors.py#L149

The calculation for mutual inc requires spinc and splan to be in radians not degrees. This is causing random rejections of mutual inclination values that should be valid. Make sure to convert all angles to radians.

benp175 commented 2 years ago

This is now fixed.