drahak / Restful

Drahak\Restful - Nette REST API bundle
0 stars 0 forks source link

Remove \Exception from error handlers type hints (PHP7 support) #117

Closed kratkyzobak closed 8 years ago

kratkyzobak commented 8 years ago

Remove \Exception type hint from error handlers, as it's not useable with PHP7, where \Error exists as sibiling of \Exception with \Throwable parent.

To support both PHP versions (5 and 7) is not possible to use any of typehint, when expecting \Exception or \Throwable.

My suggestion in this commit is to remove typehints and keep them only in phpdoc as Tracy does.

janreges commented 8 years ago

Hello, could you merge this PR please?

Your Restful library is working well, but is not usable with PHP7 :-(

Thank you.