search

drahnr / cargo-spellcheck

Checks all your documentation for spelling and grammar mistakes with hunspell and a nlprule based checker for grammar
Apache License 2.0
314 stars 32 forks source link

bump deps #284

Closed drahnr closed 1 year ago

drahnr commented 1 year ago

What does this PR accomplish?

Bumps dependencies

📜 Checklist

gilescope commented 1 year ago

We really will need the toml edit crate bumped as if you try and run the tool when the new Cargo.toml workspace properties are used then it blows up. (E.g. version.workspace = true in some of the crates in the workspace rather than specifying the version in multiple locations.)

drahnr commented 1 year ago

I'll take a look tomorrow~ish

If you have a regression test handy, that'd be much appreciated. The comment is not quite enough. Why would it blow up? Because if how it's used here or in the lib itself?

gilescope commented 1 year ago

It's something to do with '.' properties and how that's interpreted. I have been upgrading every tool I come across to latest toml edit which does understand the latest format. It's not just you - I think we are the first to use this stuff.

gilescope commented 1 year ago

Here's an example PR of what we're trying to do: https://github.com/paritytech/polkadot/pull/6095

drahnr commented 1 year ago

that PR fails since the bash eval already fails, it doesn't even get to the point cargo spellcheck tries to eval

cargo spellcheck list-files -vvv $(git diff --diff-filter=AM --name-only $(git merge-base ${CI_COMMIT_SHA} ${CI_DEFAULT_BRANCH} -- :^bridges))
gilescope commented 1 year ago

This is the error I get if we ignore bash:

[2022-11-23T09:44:24Z DEBUG cargo_spellcheck::config::args] Using /home/gilescope/git/polkadot1/Cargo.toml manifest as anchor file
Error: 
   0: Failed to parse cargo manifest: /home/gilescope/git/polkadot1/Cargo.toml
   1: invalid type: map, expected a sequence for key `package.authors` at line 11 column 21