fix dead_code compile error

drahnr / cargo-spellcheck

Checks all your documentation for spelling and grammar mistakes with hunspell and a nlprule based checker for grammar

Apache License 2.0

314 stars 32 forks source link

fix dead_code compile error #328

Closed newAM closed 2 months ago

newAM commented 2 months ago

What does this PR accomplish?

🩹 Bug Fix

Changes proposed by this PR:

Rust 1.77 merged unused_tuple_struct_fields into dead_code, which resulted in the build failing because #![deny(dead_code)] is set in src/lib.rs.

Notes to reviewer:

📜 Checklist

[ ] Works on the ./demo sub directory
[x] Test coverage is excellent and passes
[ ] Documentation is thorough

drahnr commented 2 months ago

Hey @newAM , thank you for the PR!

I think CommonLang can either be removed entirely (my preference, from a quick glance shouldn't be used anywhere anyways) or annotated with an allow(dead_deadcode) exception. I don't think the current approach is the right way.

@matthiasbeyer I don't think we're aligned on the quality bar for cargo-spellcheck :)

newAM commented 2 months ago

Sounds good, I removed the CommonLang type!