search

drahnr / oregano

Schematic capture and circuit simulator
https://ahoi.io
GNU General Public License v2.0
214 stars 39 forks source link

ld `gtk_show_uri_on_window ()` missing #212

Closed drahnr closed 7 years ago

drahnr commented 7 years ago

gtk_show_uri_on_window () is new with gtk+ 3.22 a) ubuntu has an older gtk+ version b) ubuntu provides a patched gtk+ version which does not provide this

https://developer.gnome.org/gtk3/stable/gtk3-Filesystem-utilities.html#gtk-show-uri-on-window

https://ci.spearow.io/teams/main/pipelines/oregano/jobs/pr-build-pkg-deb/builds/40

@gtrentalancia can you have a look into this?

drahnr commented 7 years ago 
# pkg-config --modversion "gtk+-3.0"
3.18.9
NAME="Ubuntu"
VERSION="16.04.2 LTS (Xenial Xerus)"
PRETTY_NAME="Ubuntu 16.04.2 LTS"

This implies to either use an if/else macro around this or to bump Ubuntu to 17.04

gtrentalancia commented 7 years ago

Fixed here:

https://github.com/gtrentalancia/oregano/commit/9dee73babf3c2b83d324be5b2ce7a93e3be2806b

I will now create a pull request for this and another minor improvement.