search

draios / instruqt-assets

3 stars 3 forks source link

[falco-rule-exceptions] track creation review #2

Closed pmusa closed 2 years ago

pabloopez commented 3 years ago

Related to this PR on draios/instruqt.

pabloopez commented 3 years ago

The only thing I do not like about this approach is that it is clear which rule needs to be modified in challenge 3. But when the append feature is merged this changes.

pmusa commented 2 years ago

I totally agree that things are too explicit. We could remove the "challenge X" comment and sort the rules to make it not so obvious.

pabloopez commented 2 years ago

I totally agree that things are too explicit. We could remove the "challenge X" comment and sort the rules to make it not so obvious.

done, I am merging this