[common] services not detected by agent

draios / instruqt-assets

3 stars 3 forks source link

Closed pabloopez closed 2 years ago

pabloopez commented 2 years ago

pmusa commented 2 years ago

pmusa commented 2 years ago

As discussed in slack, the entire k8s_extra_resources should be removed.

pabloopez commented 2 years ago

agreed!

pmusa commented 2 years ago

That is quite some change. Unfortunately, I dont have to knowledge to comment on it.

mfncl99 commented 2 years ago

Per discussion, looks good to me. Broadly, one of the three scenarios applies to the agent settings under proposal for being discarded:

The setting is legacy and is now part of the default agent configuration
The setting covers a narrow lab-specific use case and thus does not belong in master.
Other settings are there for troubleshooting purposes (extra logging, etc) and can be left out