cmake: Check USE_BUNDLED_DEPS before getting nlohmann-json.

draios / sysdig

Linux system exploration and troubleshooting tool with first class support for containers

http://www.sysdig.com/

Other

7.8k stars 728 forks source link

cmake: Check USE_BUNDLED_DEPS before getting nlohmann-json. #1869

Closed eiffel-fl closed 2 years ago

eiffel-fl commented 2 years ago

Hi.

In this PR, I added a check to USE_BUNDLED_DEPS before getting nlohmann-json. Indeed, this is only package which is always downloaded no matter what is the value of USE_BUNDLED_DEPS and the behavior all of always getting the package can not be the desired one.

This patch was written to add sysdig/falcosecurity-libs to buildroot.

If you find any way to improve this contribution, feel free to share.

Best regards.

FedeDP commented 2 years ago

Hi! I think we did it like this, because that's what Falco does. I also think it should not be an issue to accept your proposal though.

/cc @LucaGuerra

eiffel-fl commented 2 years ago

Thank you for the merge! I think it does not change something to you but it really help in buildroot case.