fix(userspace/sysdig): fixed a couple of bugs.

draios / sysdig

Linux system exploration and troubleshooting tool with first class support for containers

http://www.sysdig.com/

Other

7.8k stars 728 forks source link

fix(userspace/sysdig): fixed a couple of bugs. #1874

Closed FedeDP closed 2 years ago

FedeDP commented 2 years ago

print json root "slices" even in minimal build
always print the json closing chars

Signed-off-by: Federico Di Pierro nierro92@gmail.com

Note: this revert part of https://github.com/draios/sysdig/pull/1825: see https://github.com/draios/sysdig/pull/1825#discussion_r781070784.

FedeDP commented 2 years ago

@ldegio since i reverted a line from your PR; care to give this a look?

LucaGuerra commented 2 years ago

To add some context, we tried to run csysdig with all Lua views with and without the line printf("]}\n");. It seems to always work with that line. What we couldn't figure out is which cases was that commit in #1825 fixing.

FedeDP commented 2 years ago

Yep; at the moment, it seems like we always print an invalid json. Thanks Luca for pointing it out :)