search

drajer-health / eCRNow

Repository for eCRNow app.
Apache License 2.0
39 stars 51 forks source link

Report creation reuses identifiers #365

Open rdingwell opened 2 years ago

rdingwell commented 2 years ago

The CreateReport action passed the output dataRequirements id of the reporting bundle to the report creation classes. The report creation classes then utilize that id passed in as the id of the create content reporting bundle. As there are individual resources they should have unique identifiers generated for each content bundle.

This can be addressed by either generating a new id and passing it through to the report creating objects or by generating the new identifier in the report creating classes themselves. I would have changed this by modifying the CreateReport action to generate a new identifier for each bundle and then pass that into the ReportCreator class and issued a PR for it. But, I'm not certain if there was a reason for passing the dataRequirements id into the creation methods beyond setting the id that I'm not aware of so I added this issue instead.

nbashyam commented 2 years ago

This is interesting, because we will have to use the previously generated eICRs and other reports based on their Ids. This will require some time to analyze , maybe after the connectathon..I can look into it next week prior to our check in call.

rdingwell commented 2 years ago

@nbashyam have you had a chance to look into this?

nbashyam commented 1 year ago

@Rob - Is this somethign that needs to be addressed ?

rdingwell commented 1 year ago

It should be. New reports are being created each time so they should have unique IDs.