drajer-health / uds-plus

HRSA UDS+ FHIR IG Repository.
Creative Commons Zero v1.0 Universal
9 stars 0 forks source link

Observation.effectiveDateTime (Sexual Orientation) is not truncated #69

Open anthonygalba opened 4 months ago

anthonygalba commented 4 months ago

Effective DateTime is not listed among the dates that need to be truncated to year on the UDS+ Sexual Orientation Resource IG page (https://fhir.org/guides/hrsa/uds-plus/StructureDefinition-uds-plus-sexual-orientation-observation.html). It looks like the other Observation-based resources do call this out as needing truncation, so I'm guessing this one was just missed.

Inferno does not validate this date is truncated, however the UDS+ testing sandbox does. Please update the IG to call out that this date needs to be truncated as well.

anthonygalba commented 4 months ago

I also noticed Observation.issued on lab observation and clinical result observation is not called out as needing to be truncated. However, the UDS+ sandbox does not throw any errors when we don't truncate that. So I'm not clear if those should be truncated or it's fine to send the full instant.

nbashyam commented 3 months ago

The updates being done for 1.0.2 will be pushed to include these date truncation requirements as constraints and will be incorporated into INFERNO also and can be validated before submitting data to HRSA.

nbashyam commented 3 months ago

Also, since the instant data type has a constraint in the FHIR Spec and does not allow the truncated date, we are planning to create an extension of "issuedDateTime" which is of dateTime data type and allows for the truncation. Let us know if there are any concerns on this approach.

anthonygalba commented 3 months ago

As discussed at office hours today, that seems like a reasonable solution