search

drakhart / ha-super-soco-custom

Custom component for integrating your Super Soco or Vmoto Soco motorcycle into Home Assistant. It provides meaningful data like power status, battery percentage, location and a lot more.
MIT License
17 stars 3 forks source link

Publish API implementation separately into Pip #2

Open apbarratt opened 2 years ago

apbarratt commented 2 years ago

Your API implementation is clean and easy to read.

Could we perhaps publish it as a separate git repo on git hub and link it up with pip some how? That way someone could just run pip install socoPy and then have a simple import socoPy to utilise it :)

It would allow for a one stop shop for all python implementations to use a single wrapper of the API and for a community of open source folk to fork and submit PRs to it when API changes should be needed without everyone having to implement changes themselves :)

drakhart commented 2 years ago

Hi Andy! Thanks for your feedback, really appreciated.

You're right, that'd be ideal, and as you might have guessed that's why I coded the Super Soco API to be as "clean and easy to read" as possible: I do plan on publishing it on pypi before this integration reaches its first stable version.

To be honest I didn't do it before only because I was still hoping for Vmoto Super Soco to reply to my request and give their thumbs up to publishing all this, API client included, but it's already been months so I don't think that will ever happen. Now I just hope I don't ever receive a thumbs down either.

So yeah, tl;dr: rest assured that I will eventually publish the Super Soco API client separately on pypi, and also look into either publishing or potentially using existing API clients for OpenStreetMaps and Open Topo Data.