Add support for custom headers in SFTPGo provider

aanogueira commented 7 months ago

This pull request adds support for custom headers in the SFTPGo Terraform provider, facilitating the inclusion of additional headers in requests to the SFTPGo API. This feature is particularly useful for scenarios like bypassing IAP on Google Cloud Platform by allowing additional headers like "Proxy-Authorization".

Changes:

Added a new optional field headers in the provider configuration schema, enabling users to specify custom headers as key-value pairs.
Integrated the headers field into the provider implementation, allowing these headers to be included in requests to the SFTPGo API.
Provided an example usage of the headers field in examples/iap/main.tf, demonstrating how to pass custom headers such as "Proxy-Authorization" to bypass IAP.
Reverted go version back to 1.21 since 1.22 is missing toolchain for darwin/arm64 based machines

Please review and merge at your earliest convenience.

aanogueira commented 7 months ago

@drakkan do you find this an interesting feature to add to the project? I can also add more test cases to this, we find this new feature relevant. I'm curious about you input here. :)

drakkan commented 7 months ago

@drakkan do you find this an interesting feature to add to the project? I can also add more test cases to this, we find this new feature relevant. I'm curious about you input here. :)

yes, this is an interesting feature, but I have very little time at the moment, so make sure to fully test this change in your branch and confirming it works as expected before proposing it for review. Thanks for your patience

aanogueira commented 7 months ago

Yes, I've already tested it, been using the fork I've created and it works just fine.

CLAassistant commented 5 months ago

All committers have signed the CLA.

drakkan commented 5 months ago

Merged with some minor changes, added you as co-author.

Thank you for this useful contribution and sorry for the ridiculous amount of time it took to merge this relatively simple patch. Unfortunately managing open source software isn't just about writing code, we were distracted by legal aspects like the CLA, thanks for signing it.

A new release will be tagged along with sftpgo 2.6.0

drakkan / terraform-provider-sftpgo

Add support for custom headers in SFTPGo provider #7