search

drakkar-lig / debootstick

Generate a bootable live image from any Debian/Ubuntu filesystem tree.
62 stars 18 forks source link

grub-install doesn't have --force-extra-removable in Ubuntu #39

Closed mohanjith closed 2 years ago

mohanjith commented 2 years ago

In the proposed change it detects the OS and selects the right flag.

--removable will add extra binary needed

eduble commented 2 years ago

Hello, Sorry for the delay. Thanks for looking at it, but I actually met this case too and commited the following fix https://github.com/drakkar-lig/debootstick/commit/e6096bbca0f64867160562f00b3b566387a2d3d3 a few months ago. It is available in branch dev, which is the most advanced one and supposed to be merged in master after sufficient testing. Do not hesitate to report any issue with this branch. Thanks Etienne

mohanjith commented 2 years ago

Any plans to release these changes anytime soon?

eduble commented 2 years ago

I actually realised your patch also handles possible option "--removable", my code did not, so I just committed one more update on top of dev. About release plans, I am quite busy these days, but it depends how many people are waiting on this... Is there a reason why you branched on secure-boot and not master? Did you need specific features which are not in master yet, like secure boot or 4K disks? Apart from this issue you reported, did it work well?

mohanjith commented 2 years ago

I need secure-boot. Even a PPA release would be welcome with secure boot.

mohanjith commented 2 years ago

Yep, secure-boot branch worked very well except for the minor issue I bumped into.

eduble commented 2 years ago

I understand. I publish packages to debian so it takes much time before they are available in ubuntu. I will run tests next wednesday january 19 and if all goes well then I will publish a ppa. Thanks for the info about secure-boot usage.

mohanjith commented 2 years ago

Thank you very much!

eduble commented 2 years ago

I actually realised your patch also handles possible option "--removable", my code did not, so I just committed one more update on top of dev.

It seems that adding this --removable option when available (on ubuntu) broke UEFI boot, at least when testing on kvm (without secure-boot). The grub UEFI binary installed in this case seems unable to handle the LVM setup.

Without it, everything boots fine in my case. Thus I reverted the last change I did on branch dev.

Which version(s) of ubuntu do you need a ppa package for?

mohanjith commented 2 years ago

20.04 (focal)

Thanks!

eduble commented 2 years ago

Here is the ppa with updated debootstick (new version built for 20.04, 21.10 and 22.04): https://launchpad.net/~debootstick/+archive/ubuntu/ppa

mohanjith commented 2 years ago

Thank you very much. I will test it out.