drakkar-lig / walt-python-packages

Home of walt-node, walt-server, walt-client and walt-common python packages.
https://walt-project.liglab.fr
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Log checkpoints are not case sensitive. #30

Closed sandikkaya closed 5 years ago

sandikkaya commented 5 years ago

Log checkpoints could be helpful to pinpoint a certain time while inspecting logs.

One disruptive behavior of current checkpoint mechanism is it is not case sensitive; which may lead to a family of unexpected behavior.

Consider the following scenario after walt log add-checkpoint EXP1 is used to indicate the beginning of first experiment:

user@waltsrvr:~$ walt log list-checkpoints
timestamp                   name
--------------------------  ----
2018-01-01 01:01:01.513851  EXP1
user@waltsrvr:~$ walt log show --history EXP1: --streams mystream
Failed: no checkpoint with this name 'exp1'.
Invalid HISTORY_RANGE. See 'walt help show log-history' for more info.

This unexpected behavior could be fixed by either enabling case sensitivity or, recording added checkpoints in small-letters.