search

drakkar-lig / walt-python-packages

Home of walt-node, walt-server, walt-client and walt-common python packages.
https://walt-project.liglab.fr
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Use of `service ... restart` commande instead of `systemctl restart ...` #63

Closed audeoudh closed 1 year ago

audeoudh commented 3 years ago

https://github.com/drakkar-lig/walt-python-packages/blob/1bf1fe6a27252e922d2dd0210dc2b5a16ec78f89/server/walt/server/threads/main/network/dhcpd.py#L254

Here, you use service command not available on some new systems with systemd only and no init-equivalent bindings.

Moreover, in the docs, we suggest to use a systemd service for that unit. Wouldn't systemctl restart isc-dhcp-server.service be better?

eduble commented 3 years ago

Sure. walt was created before systemd so this sort of legacy code can exist.