dralletje / Windowed

Chrome extension to keep fullscreen windows contained
167 stars 16 forks source link

[Feature request] Support for TradingView #41

Closed tobia closed 2 years ago

tobia commented 2 years ago

I tried using this extension to keep a floating TradingView chart on top of my screen at all times, but the fullscreen button (top toolbar, third from the right) just goes into fullscreen, without being intercepted by this extension.

dralletje commented 2 years ago

Do you have an easily reproducible example for me?

tobia commented 2 years ago

Sure. You can just open the default chart at https://www.tradingview.com/chart/ and use the fullscreen icon:

Screenshot 2022-02-11 at 00-19-06 Live stock, index, futures, Forex and Bitcoin charts on TradingView

dralletje commented 2 years ago

Thanks!

Will look more into it, but just to confirm: you are getting the popup? For me the page does jump into a fullscreen-ish mode and then shows me the popup, but selecting windowed will just force it into fullscreen anyway:

image

tobia commented 2 years ago

I get no popup, it just goes into fullscreen. I also tried changing the default mode for the website, using the toolbar icon, but no matter what I choose it always goes into fullscreen, ignoring the extension.

But I noticed the following errors in the console:

windowed-error

I'm using Firefox 96.0 (64-bit) for Ubuntu, but yesterday I was using the latest Firefox on Windows. I also tried creating a new Firefox profile, without any extensions or custom settings except for Windowed, and I get the same behavior and the same error message.

I'm no expert at Content Security Policy, but it might be that TradingView (and others) are enabling some optional high-security settings that block unsigned scripts, like Windowed's injected one, from running.

dralletje commented 2 years ago

Ah, you're on firefox! I was expecting Chrome 😁 I'll test on firefox!

dralletje commented 2 years ago

Okay, got it! Can you upgrade windowed and try it out?

tobia commented 2 years ago

It works perfectly! Thank you! 🎉