Test code uses certificates, which are available only locally

drallgood / jpasskit

jPasskit is an Java™ implementation of the Apple™ PassKit Web Service.

Apache License 2.0

275 stars 109 forks source link

Test code uses certificates, which are available only locally #42

Closed stepio closed 9 years ago

stepio commented 9 years ago

Class de.brendamour.jpasskit.server.PKRestletServerResourceFactory contains constant path values for the certificates:

    protected static final String APPLE_WWDRCA_CERT_PATH = "/Users/patrice/Documents/bitzeche/Projects/passkit/AppleWWDRCA.pem";
    protected static final String PKCS12_FILE_PATH = "/Users/patrice/Documents/bitzeche/Projects/passkit/Certificates.p12";

Why aren't these certificates available as test resources? Is it a bug or more like a known limitation?

drallgood commented 9 years ago

Oh... I probably never got around to cleaning this up. There are more local paths in this file than just the ones to the certificates.

Definitely a bug