search

dralshehri / hijridate

Accurate Hijri-Gregorian dates converter based on Umm al-Qura calendar
https://hijridate.readthedocs.io
MIT License
67 stars 14 forks source link

not as ummulqura calender #9

Closed NoraD1 closed 2 years ago

NoraD1 commented 2 years ago

Thank you for hijri-converter as it is very helpful. I would like to inform you that we found some inaccurate dates as shown below:

image Gregorian_Date: 1983-10-31 Hijri_converter: 1404-01-25

while in (https://www.ummulqura.org.sa/Index.aspx) is : image

ummulqura calender: 1404-01-24

sample of other dates that have the same issue: <html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns="http://www.w3.org/TR/REC-html40">

  |   |   |   |   -- | -- | -- | -- | --   | gregorian_date | hijri_converter | ummalqura_calender |     | 08/08/1989 | 1410-01-07 | 1410-01-06 |     | 22/12/1989 | 1410-05-24 | 1410-05-23 |     | 11/07/1990 | 1410-12-19 | 1410-12-18 |     | 26/09/1990 | 1411-03-07 | 1411-03-06 |     |   |   |   |  

Thanks in advance

dralshehri commented 2 years ago

I appreciate your feedback 🙏🏼

Unfortunately, the official converter at Ummulqura Calendar website has some issues.

I know it is confusing, but check these calendars on the same website: 1404 1410 1411 and you will find the discrepancies.

The hijri_converter was carefully developed using the tables at Ummulqura Calendar website and verified using several other official sources such as Umm al-Qura newspaper and Umm al-Qura Comparative Calendar (issued by Saudi Ministry of Finance).

Perhaps we need to contact people behind Ummulqura Calendar website to fix their converter.