drannex42 / FirefoxSidebar

Vertical tab design for Firefox with dynamic indentation:: Sidebery and TreeStyleTabs (Legacy) themes available!
218 stars 24 forks source link

v2024.05.15 - how to use full width for URL bar? #49

Open xfzv opened 4 months ago

xfzv commented 4 months ago

I've updated to v2024.05.15 today.

Before, the URL bar used to use the full width: image

Now, the sidebar takes the full height: image

How could I get the old behavior back?

I tried to enable superbox_removal.css again in userChrome.css:

@import url("./extensions/superbox_removal.css");

but it doesn't make any difference. I noticed that the extension was not just commented but actually removed from userChrome.css so I guess it's no longer compatible with v2024.05.15 (not sure why superbox_removal.css file is still in the repo though).

Thanks!

drannex42 commented 4 months ago

Interesting — you must have had a bug this entire time! The address bar was never intended to be full width. The sidebar was supposed to be entirely on the left side. Your address bar was actually blocking the ability to switch different sidebars this entire time.

The superbox_removal removal wouldn't have "fixed" this issue for you either, it's more than likely due to how we rewrote the core sidebar file and how it positions itself to be a fair bit more stable and less buggy.

I should be able to write a way to enable a full address bar, but it'll take some time to figure out how to properly put that into place.

You do though, I believe, need to enable either your bookmark bar, or enable the bookmark bar fix to have that position itself properly from what I can sort of tell from those screenshots.

Edit: I left the superbox_removal because I intend to clean up the code and fix the various layout issues eventually.

xfzv commented 4 months ago

The address bar was never intended to be full width. The sidebar was supposed to be entirely on the left side. Your address bar was actually blocking the ability to switch different sidebars this entire time.

Oh, I see. I've just tried with a fresh Firefox profile and now I understand.

I have "Bookmarks toolbar" set to "Never show", I use Sidebery built-in "Bookmarks" navigation bar element instead and Ctrl+H to see history so it never bothered me.

On a fresh profile with fix_hidden_bookmarks.css enabled, the sidebar switcher is still visible by a few pixels on my end, I can click on it: image

hide_sidebar_switcher.css looks like what I need to use instead, but it overlaps the previous/next buttons: image

Plus, the down arrow and my navigation bar elements are not visible. Pressing Alt key to display Firefox menu bar shows them half so I guess they're placed too high. This is most likely fixable via custom.css but considering this is with a fresh profile without any other tweak, I don't think that it's supposed to behave this way.

Any idea? I'm using Firefox 126.0 with AwesomeWM if that matters, so I don't have any window title bar (only thin borders).

I should be able to write a way to enable a full address bar, but it'll take some time to figure out how to properly put that into place.

No worries, there's nothing wrong with the current look. I got used to it very quickly.

Edit: I left the superbox_removal because I intend to clean up the code and fix the various layout issues eventually.

OK :+1:

xfzv commented 4 months ago

I somehow fixed it:

image

image

@import url("./extensions/hide_sidebar_switcher.css");

custom.css:

#sidebar-box {
  padding-top: 32px !important;
}

.browser-toolbar {
  padding-left: 50px !important;
}

I'm satisfied with the result but feel free to suggest any better tweak!

Thank you for your time.

drannex42 commented 4 months ago

Thanks for filing the issue! I'll take a look, there might be some additional testing needed to set the values properly for most people on first load. I'll take a look around next week and try to get a fix sent out.

There also has to be a way to autodetect the bookmark bar, I'll see if there is anything in about:config to detect and apply CSS. Unsure if possible, but I hope so!

I'll keep the issue open until I find out more.