search

drapanjanas / re-natal

Bootstrap ClojureScript React Native apps
MIT License
1.22k stars 98 forks source link

Discussion: Integrate boot to avoid fragmentation #53

Closed vikeri closed 8 years ago

vikeri commented 8 years ago

As the essay of the lisp curse predicts we already have some fragmentation in the very young CLJS RN space: re-natal vs boot-react-native. re-natal is clearly the most popular one if you judge from number of stars and forks here on GitHub. I am pretty sure that as RN usage grows in the CLJS community people are going to want to use boot since it seems to be very popular for the web/node. While the fragmentation between boot and lein are reasonable since they represent different philosophies I do not feel the same is true for re-natal vs boot-react-native and therefore I'd like to raise the question if these projects could be merged or that re-natal would add boot to the roadmap.

vikeri commented 8 years ago

Same issue in boot-react-native: https://github.com/mjmeintjes/boot-react-native/issues/48

tiye commented 8 years ago

I'm voting for Boot too. My toolchains has bugs in figwheel https://github.com/bhauman/lein-figwheel/issues/399 so I really hope there's a Boot solution I can use.

arichiardi commented 8 years ago

It would be great, boot is way better at programmatically adding files to the classpath and potentially solve the already fragmented world of js dependencies (Webpack, CommomJS, ...). What is to be done?

drapanjanas commented 8 years ago

This is a good discussion. I have not uesd boot yet, but I have quite hight it on my "try/learn" list. Though I am not too convinced that same CLI tool like re-natal should support workflow with both build tools. I would rather prefer to have a separate CLI for example boot-natal (you name it) and implement something what is needed for the workflow with boot but outside of project build tasks. In that sense I see no clear benefits of actually merging boot-react-native with re-natal. Maybe we could build something like natal/re-natal CLI to generate boot-react-native templates? My arguments for not mixing up lein and boot in same CLI tool:

  1. re-natal is very specific to development workflow with figwheel (and therefore lein), so many of commands would not make sense for boot project I guess, as probably same could be implemented as build tasks
  2. I think the templates would be a bit different with boot from those currently generated, like files in env/ sources which are figwheel specific
  3. If implementation is not designed right, re-natal will be way more complex and require be more work to maintain and extend (so noone would do it and it would just die)

It is not very clear to me what boot-react-native does not have compared to re-natal. Is it only the initial project generation for different react wrappers? Otherwise it seems more less same, no? Re-natal is actually more hacky solution (in respect to React Native) because it bypass the packager via figwheel.

vikeri commented 8 years ago

Good points, maybe they should be different cli tools but share a library where things in common can be found:

I'm just feeling that since we are such a small community it is a shame that people are solving the same issue in various places. Being small gives us the opportunity to think things through and build a good modular core that ensures a common foundation while allowing for modular extensions (boot/lein, om/reagent etc.). Not sure if this is the way to go, I have limited insight in boot for example, but I believe these things ought to be pondered at least 😄

I tried boot-react-native at first but I couldn't get things working so I switched to re-natal which has been a superior experience for me so far.

pesterhazy commented 8 years ago

We've been using boot-react-native since its beginning, and after a few rough weeks in the beginning it's working very well for us. The approach of using the RN packager is very powerful, as there is a very similar environments for debug ("online" bundle) and release ("offline" bundle).

We also have a "one click" workflow, where running boot dev --platform ios does a lot of things:

Additionally of course also there's automatic reloading of code. You can also just require npm dependencies, and they'll automatically get picked up. Everything reloads in 2 seconds or less. I think this interactivity is very important.

I've also felt that it's unfortunate that there's a split between re-natal and boot-react-native, and would be happy to help joining the efforts.

vikeri commented 8 years ago

@pesterhazy Alright good to hear. What are your thoughts on at least unifying some common elements of the two libraries?

In general I sort of got the feeling that boot-react-native was semi-abandoned? RN is moving at a fast pace and boot-react-native has not been updated in a while. @drapanjanas has been doing a great job of maintaining the pace.

pesterhazy commented 8 years ago

@vikeri I'd like to help get b-r-n updated in the new future. I certainly haven't abandoned it, though I agree that code and docs badly need a fresh code of paint.

Which parts do you think could be unified? I'd certainly like to see more wrappers for r-n js libraries in cljs, but those should work for either project.

vikeri commented 8 years ago

@pesterhazy: I've understood from slack that it is still under development and that you are using it, awesome! Yeah, since it is a fairly new project for a completely new thing, docs seem quite important. Basically the things I mentioned in https://github.com/drapanjanas/re-natal/issues/53#issuecomment-221561751

Off topic: Very confusing that you have different avatars on slack and github 😉

vikeri commented 8 years ago

I've now create an (eventually) agnostic lib where we could put some common tools: https://github.com/vikeri/rn-cljs-tools

I wrote it in bash but it might be better to have it writte in js for example so then one may use it with npm install -g.