draperjames / qtpandas

Qt Meets Pandas
MIT License
140 stars 53 forks source link

Failing or broken pytests #23

Open draperjames opened 7 years ago

draperjames commented 7 years ago

In PR #22 running pytest on the tests directory has been yielding weird results ever since I started messing around with the decorators. Mostly I have been converting methods to functions using @classmethod and changing self to cls. I did all that b/c codacy suggested but as far as I can tell this is mostly just making things more difficult. If we need to lose all that bullshit we def can. I can just tell codacity to ignore that problem pattern and the score should improve, but I don't wanna cheat if I don't have too :wink:.

zbarge commented 7 years ago

@draperjames I added this guide - what do you think? Maybe it should be broken out into more parts, idk..

https://github.com/draperjames/qtpandas/wiki/Installation-Guide

draperjames commented 7 years ago

@zbarge it looks great I'll add in the PySide/PyQt install directions.

draperjames commented 7 years ago

I commented out a few tests that have been consistently failing for me in PR #30, it's currently passing all tests found. @zbarge try it and see what you get. We establish a baseline and work out from there. Once we have a version that passes all tests we can systematically remove the comments and diagnose the issues one at a time. Or just leave them commented out.