draperjames / qtpandas

Qt Meets Pandas
MIT License
140 stars 53 forks source link

There's wrong in qtpanas.models.DataFrameModel.py #41

Closed soaringsoul closed 6 years ago

soaringsoul commented 7 years ago

line 557:self._dataFrame.sort(column, ascending=not bool(order), inplace=True) is wong

when you click the columns name in gui, it will course a misktake which leads to stop working.

in latest pandas verson ,df.sort() has relplaced by df.sort_values,

so, in line 557, it shoud witer like this: self._dataFrame.sort_values(column, ascending=not bool(order), inplace=True)

zbarge commented 6 years ago

Fixed - thank you & sorry for the delay.