search

draperlaboratory / VIBES

Verified, Incremental, Binary Editing with Synthesis
MIT License
51 stars 1 forks source link

"Outs" field of vibes IR not being populated #159

Closed philzook58 closed 2 years ago

philzook58 commented 2 years ago

Vibes ir is intended to be annotated with which variables are live coming in and live going out of a block. These go in the ins and outs operands of the block. It does not appear to me the outs field is being populated. This is intertwined with the linear SSA pass as the information needed to do this is in the congruence information combined with block reachability. Do we need to maintain more info to do this more easily?

philzook58 commented 2 years ago

The "ins" field needs serious thought as well. Is it even possible to express optionality with in the ins with Ir.t structured as it is?

philzook58 commented 2 years ago

Addressed in #168