draperlaboratory / VIBES

Verified, Incremental, Binary Editing with Synthesis
MIT License
51 stars 1 forks source link

Move type defs to hvars #193

Open philzook58 opened 2 years ago

philzook58 commented 2 years ago

User friendliness suggestion. Arguably there is some duplication of information in two different spots. We declare vars in both C patch and in hvars. FrontC needs the declarations. We could splice in the computed type declarations to the patch string.

ivg commented 2 years ago

It is not clear why do you need to declare them at all. The parser needs only to know the type names, not the variable names. And type names could be easily declared via the Clexer.add_type.