draperlaboratory / VIBES

Verified, Incremental, Binary Editing with Synthesis
MIT License
51 stars 1 forks source link

Failing tests in main #85

Closed codyroux closed 3 years ago

codyroux commented 3 years ago

We're skipping a couple tests in main, namely those that depend on: https://github.com/draperlaboratory/VIBES/blob/db7e630bded36bd5fa5db9d1189bc44a319c9084/bap-vibes/src/patcher.ml#L307

because the invocation to Ogre is insufficiently well mocked in dummy tests, and raises an error.

Proposed solution: make that invocation a default argument, with the possibility to supply an override for testing purposes (or other, say if we have a different source for the region address and offset).

codyroux commented 3 years ago

Fixed!