Fortunac/arm - Githubissues

draperlaboratory / cbat_tools

Program analysis tools developed at Draper on the CBAT project.

MIT License

102 stars 14 forks source link

Fortunac/arm #290

Closed fortunac closed 3 years ago

fortunac commented 3 years ago

Fixes #285. Adds support for ARM, most notably:

the function spec for chaosing caller-saved registers
setting SP to the defined region
printing the memory model when outputting gdb and bildb init scripts

I did not create ARM versions of the chaos-rax or rax-out specs in favor of using the arg-terms and chaos-caller-saved-registers specs. If we want to create a chaos-R0 spec, that can be done easily.

codyroux commented 3 years ago

As usual, very clean and pleasant implementation!

We just need to agree on the default behavior on "non-supported" architectures: currently it fails with --compare-regs, I think. My intuition is that it should proceed with warning and an empty set?

Not sure.

fortunac commented 3 years ago

As usual, very clean and pleasant implementation!

We just need to agree on the default behavior on "non-supported" architectures: currently it fails with --compare-regs, I think. My intuition is that it should proceed with warning and an empty set?

Not sure.

I have no problems with printing a warning and returning an empty set.

codyroux commented 3 years ago

Let's do that then. You may then merge at will AFAI am concerned.